Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on PHP8 #1077

Merged
merged 8 commits into from
Dec 24, 2024
Merged

Fix warning on PHP8 #1077

merged 8 commits into from
Dec 24, 2024

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Dec 13, 2024

refs #1058
refs #1045

PHPUnit 及び E2Eテストで出る Warning の解消

setasign/fpdf で出る Warning は PR 済み(Setasign/FPDF#22)
[Standard input code] Warning(E_WARNING): Undefined array key "subsetted" on [/var/www/app/data/vendor/setasign/fpdf/fpdf.php(1658)]
module/fpdi/japanese.php を修正

E2Eテストで出る Warning 解消
PHPUnit で出る Warning 解消
@nanasess nanasess changed the title PHP8 で出る Warning の修正 Fix warning on PHP8 Dec 13, 2024
@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
@nanasess nanasess enabled auto-merge December 17, 2024 06:11
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 73.01587% with 34 lines in your changes missing coverage. Please review.

Project coverage is 50.94%. Comparing base (4b3b997) to head (fe901da).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
data/class/SC_Initial.php 0.00% 11 Missing ⚠️
data/class/helper/SC_Helper_HandleError.php 0.00% 6 Missing ⚠️
data/class/SC_Response.php 50.00% 5 Missing ⚠️
...ss/sessionfactory/SC_SessionFactory_UseRequest.php 0.00% 4 Missing ⚠️
data/class/SC_ClassAutoloader.php 50.00% 2 Missing ⚠️
data/class/plugin/SC_Plugin_Util.php 0.00% 2 Missing ⚠️
...ass/sessionfactory/SC_SessionFactory_UseCookie.php 0.00% 2 Missing ⚠️
data/class/helper/SC_Helper_Session.php 0.00% 1 Missing ⚠️
data/class/plugin/SC_Plugin_Installer.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
- Coverage   51.64%   50.94%   -0.70%     
==========================================
  Files          80       80              
  Lines       10224    10256      +32     
==========================================
- Hits         5280     5225      -55     
- Misses       4944     5031      +87     
Flag Coverage Δ
tests 50.94% <73.01%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nanasess nanasess merged commit 8ab728f into EC-CUBE:master Dec 24, 2024
107 of 108 checks passed
@nanasess nanasess deleted the fix-warnings branch December 24, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants